Code Review for jdk10-hotspot-hg

Prepared by:Gustavo Serra Scalet on Tue Sep 12 11:29:57 -03 2017
Workspace:/home/gut/jdk10-hotspot-hg
Compare against: ssh://10.10.71.67/jdk10-hs/hotspot
Compare against version:13436
Branch:sha_intrinsics
Summary of changes: 1265 lines changed: 1253 ins; 0 del; 12 mod; 9086 unchg
Patch of changes: jdk10-hotspot-hg.patch
Bug id: JDK-8185979 : PPC64: Implement SHA2 intrinsic
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/cpu/ppc/vm/assembler_ppc.hpp 

rev 13439 : Martin's 8185979: PPC64: Implement SHA2 intrinsic
5 lines changed: 4 ins; 0 del; 1 mod; 2358 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/cpu/ppc/vm/assembler_ppc.inline.hpp 

rev 13439 : Martin's 8185979: PPC64: Implement SHA2 intrinsic
10 lines changed: 9 ins; 0 del; 1 mod; 1060 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/cpu/ppc/vm/macroAssembler_ppc.hpp 

rev 13438 : Updating due to Martin Doerr's comments

http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2017-August/026952.html
34 lines changed: 34 ins; 0 del; 0 mod; 943 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/cpu/ppc/vm/stubGenerator_ppc.cpp 

rev 13437 : Implement SHA256 and SHA512 intrinsics for PPC64

Sample run reduced 6.5s run to 2.8s for SHA256.
30 lines changed: 30 ins; 0 del; 0 mod; 3533 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/cpu/ppc/vm/stubRoutines_ppc.hpp 

rev 13439 : Martin's 8185979: PPC64: Implement SHA2 intrinsic
1 line changed: 0 ins; 0 del; 1 mod; 74 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/cpu/ppc/vm/vm_version_ppc.cpp 

rev 13439 : Martin's 8185979: PPC64: Implement SHA2 intrinsic
35 lines changed: 29 ins; 0 del; 6 mod; 787 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/cpu/ppc/vm/vm_version_ppc.hpp 

rev 13437 : Implement SHA256 and SHA512 intrinsics for PPC64

Sample run reduced 6.5s run to 2.8s for SHA256.
3 lines changed: 3 ins; 0 del; 0 mod; 119 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/compiler/intrinsics/sha/cli/testcases/GenericTestCaseForOtherCPU.java 

rev 13437 : Implement SHA256 and SHA512 intrinsics for PPC64

Sample run reduced 6.5s run to 2.8s for SHA256.
2 lines changed: 1 ins; 0 del; 1 mod; 92 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/compiler/testlibrary/sha/predicate/IntrinsicPredicates.java 

rev 13439 : Martin's 8185979: PPC64: Implement SHA2 intrinsic
6 lines changed: 4 ins; 0 del; 2 mod; 120 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/cpu/ppc/vm/macroAssembler_ppc_sha.cpp 

rev 13441 : Add contributors name on this sha implementation
1139 lines changed: 1139 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using webrev.ksh (vers 25.16-hg+openjdk.java.net).